Global Nav - Githubissues

colegoldsmith commented 2 months ago

Main updates:

When `site.keys.global_nav` is present the new nav will be displayed

New version switcher placed in the side nav

Removed the old broken version switcher in the ToC

Tested this new UI bundle without `site.keys.global_nav` with the existing playbook and the site is styled properly

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages.

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages.

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages.

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft to GitHub Pages. Deployment successful! View draft

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

kurtenj commented 2 months ago

Looking slick, @colegoldsmith! Just a few fixes:

Can we slow down the speed at which the nav dropdown appears/disappears as well as the rotation of the chevron?
Let's keep the version switcher an on-click action instead of opening the list on hover
The home nav item is missing the icon and border-right

I think we should also drop the background on hover for the nav items
Let's look at simplifying the active style, perhaps just a straight primary-main on the text

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

colegoldsmith commented 2 months ago

Thanks @kurtenj! I just pushed an update that should address all your comments.

colegoldsmith commented 2 months ago

@mlr @eric-schneider To get the special "Docs Home" styling I made it conditional on the site.keys.global_nav item having a special flag. For the home link you'll want to add home: true like this

{ 
  "title": "Docs Home",
  "xref": "home::index.adoc",
  "home": true
},

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

riptano / docs-ui

Global Nav #124

When `site.keys.global_nav` is present the new nav will be displayed

New version switcher placed in the side nav

Removed the old broken version switcher in the ToC

Tested this new UI bundle without `site.keys.global_nav` with the existing playbook and the site is styled properly

riptano / docs-ui

Global Nav #124

When site.keys.global_nav is present the new nav will be displayed

New version switcher placed in the side nav

Removed the old broken version switcher in the ToC

Tested this new UI bundle without site.keys.global_nav with the existing playbook and the site is styled properly

When `site.keys.global_nav` is present the new nav will be displayed

Tested this new UI bundle without `site.keys.global_nav` with the existing playbook and the site is styled properly