Side Nav Improvements - Githubissues

riptano / docs-ui

The UI and theme for DataStax Docs.

https://riptano.github.io/docs-ui/

Mozilla Public License 2.0

2 stars 0 forks source link

Side Nav Improvements #133

Closed colegoldsmith closed 6 months ago

colegoldsmith commented 6 months ago

Completes https://github.com/riptano/docs-ui/issues/123

Initial Ideas:

Screenshot 2024-05-09 at 2 08 57 PM

I have added these improvements

~~Nav item titles can now optionally include a link, making the expand/contract chevron a separate smaller button~~
Open in new icon for external links in the side nav and global nav dropdown items
Improved accessibility for the side nav, mainly hiding the collapsed content from screen readers until the collapse is opened

Update

I have backed out the ability for a nav item to be a link if it is a list title. The other improvements still apply

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

aimurphy commented 6 months ago

My expectation was that clicking anywhere on a parent nav item (either the link or the caret button) would reveal the next level underneath the parent.

I agree. Clicking either the caret or the parent itself should expand its children. This should also happen if you arrive directly on the parent page (like from Google or a direct link).

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

mlr commented 6 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 6 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft