search

riptano / docs-ui

The UI and theme for DataStax Docs.
https://riptano.github.io/docs-ui/
Mozilla Public License 2.0
2 stars 0 forks source link

Use node global context to get assetManifest #139

Closed colegoldsmith closed 3 months ago

colegoldsmith commented 5 months ago

Relies on an Antora extension to set the assets-manifest object on the node global context

mlr commented 5 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

mlr commented 5 months ago

@colegoldsmith looks like the Antora build was unsuccessful. It didn't post a comment back here due to the error being too long https://github.com/riptano/datastax-docs-site/actions/runs/9389755534/job/25857983644#step:11:51

oh – maybe because it needs the asset manifest extension in your other PR

eric-schneider commented 5 months ago

maybe because it needs the asset manifest extension

Yeah, the codependency between the UI and the extension creates a bit of a split-brain scenario between this PR and the one in datastax-docs-site.

github-actions[bot] commented 5 months ago

The preview build for this pull request has been cleaned up due to being stale.

Preview builds that were 2 weeks old or older were automatically removed to maintain a tidy GitHub Pages site.

You can rebuild the preview at any time by pushing a new commit to this pull request:

git checkout cache-busting-v2
git commit --allow-empty -m 'rebuild preview'
git push origin cache-busting-v2
eric-schneider commented 3 months ago

Note: This PR causes breaking changes, and depends on updated Antora extensions in https://github.com/riptano/datastax-docs-site/pull/190