search

riptano / docs-ui

The UI and theme for DataStax Docs.
https://riptano.github.io/docs-ui/
Mozilla Public License 2.0
2 stars 0 forks source link

Update syntax for sample tabs [no-release] #157

Closed aimurphy closed 2 months ago

aimurphy commented 3 months ago

I updated the syntax demonstrated in the example tabs to follow our agreed best practices.

mlr commented 3 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

github-actions[bot] commented 2 months ago

The preview build for this pull request has been cleaned up due to being stale.

Preview builds that were 2 weeks old or older were automatically removed to maintain a tidy GitHub Pages site.

You can rebuild the preview at any time by pushing a new commit to this pull request:

git checkout tab-format-19-aug-24
git commit --allow-empty -m 'rebuild preview'
git push origin tab-format-19-aug-24
mlr commented 2 months ago

UI bundle preview build successful! :white_check_mark: Deploying preview to GitHub Pages. Deployment successful! View preview

aimurphy commented 2 months ago

@eric-schneider when you have a few min, could you please review/approve?

plpesvc-ds commented 2 months ago

Antora site build successful! :white_check_mark: Deploying draft. Deployment successful! View draft

eric-schneider commented 2 months ago

@aimurphy I added [no-release] to the PR title, so hopefully it appears in the auto-generated commit title when you click Squash and merge. But if doesn't, please manually add it before confirming the merge. This prevents the automation from triggering a new UI bundle release (see the README for details).

mlr commented 2 months ago

@aimurphy I added [no-release] to the PR title, so hopefully it appears in the auto-generated commit title when you click Squash and merge. But if doesn't, please manually add it before confirming the merge. This prevents the automation from triggering a new UI bundle release (see the README for details).

Unfortunately it is based on commit message. I ran into this the other day. We (I) should update it to look at the pr title instead. If it does get added to the merge commit it should work but it doesn’t work as well as it could