riptano / docs-ui

The UI and theme for DataStax Docs.
https://riptano.github.io/docs-ui/
Mozilla Public License 2.0
2 stars 0 forks source link

Right nav doesn't take the full height of the browser window #65

Closed djsauble closed 6 months ago

djsauble commented 7 months ago

Screenshot 2024-01-16 at 9 25 23 AM

colegoldsmith commented 7 months ago

@djsauble I set the height that way to make room for the footer scrolling into view at the bottom of the page. If the ToC is full browser height it jumps up when the footer is visible. It's not the worst thing ever but it is a tradeoff with how the sticky element is stacked above a relative element.

@kurtenj Would we want to prioritize giving the ToC more height even though it would jump up a little when scrolling to the bottom?

djsauble commented 7 months ago

I'd like to see what that transition looks like, but it sounds like a reasonable tradeoff to me.