search

ris58h / youtube-timestamps

Web extension that shows timestamps from YouTube comments on timeline.
https://ris58h.github.io/youtube-timestamps/
91 stars 7 forks source link

Hormonize add-on with new youtube feature #19

Closed samwolfe2000 closed 3 years ago

samwolfe2000 commented 3 years ago

Youtube recently has added a very simular function which could work well together with this addon if small adjustments were made.

This new YT function looks a bit different (a bit more modern i guess), but does prettymuch the same, except, it only shows timestamps placed in the discription and in the beginning of a row.

I wonder if you could adjust the addon to this new feature by exluding timestamps having this new functionality. It would make the timeline more transparent in some cases.

Regards,

Samwolfe

ris58h commented 3 years ago

Hi @samwolfe2000 this has been fixed in version 0.2.2 (already available for Firefox and on review at this moment for Chrome).

samwolfe2000 commented 3 years ago

Hi (sorry, I forgot to say hello),

Thanks for your efforts, unfortunatelly I can't notice a difference on Firefox. Have you a clue what's this?

Sam

ris58h commented 3 years ago

@samwolfe2000 make sure you have 0.2.2 version of the add-on. If true, send me a link on the video page where it doesn't work so I could check what's wrong.

samwolfe2000 commented 3 years ago

It's a longer one: https://www.youtube.com/watch?v=aoajtl7BSe0

Ilya Rodionov @.***> ezt írta (időpont: 2021. jún. 24., Cs, 21:33):

@samwolfe2000 https://github.com/samwolfe2000 make sure you have 0.2.2 version of the add-on. If true, send me a link to the video so I could check what's wrong.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ris58h/youtube-timestamps/issues/19#issuecomment-867899231, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO7L64CVBRJWYVPEVEHYINTTUOCAXANCNFSM43VE5KQQ .

ris58h commented 3 years ago

Oh. I see. It looks like the reason is ending chapter timestamps. The easiest way to fix it is not to show timestamps from the description at all. Most of them a chapter timestamps anyway. But in rare cases there could be timestamps in the description that aren't about chapters.

ris58h commented 3 years ago

Since version 0.2.3 the extension doesn't show timestamps from a description.

samwolfe2000 commented 3 years ago

Yes, I think this solution is fine.

Ilya Rodionov @.***> ezt írta (időpont: 2021. jún. 26., Szo, 17:28):

Since version 0.2.3 the extension doesn't show timestamps from a description.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ris58h/youtube-timestamps/issues/19#issuecomment-869018517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO7L64E7CJQCUAE447GFW6DTUXWYLANCNFSM43VE5KQQ .