Open petermarkley opened 2 years ago
Oh, and while you compare repos you might want to take a very close look at this: https://github.com/klada/sunwait/pull/3
I'm looking at sunwait.cpp:439
and thinking that you maybe fixed only one of the two bugs that I found in 2018 (the one mentioned here). The other one was in getUtcBiasHours()
, and looks unfixed in your code.
I can't test right now to verify if I'm correct.
Notice also that in my pull request on the other repo, I changed a variable name to remove the false assumption of UTC in the code logic.
I told the maintainer of the other repo. He archived his repo and added a link to yours.
When I get time, I'll try to create a pull request here that fixes the bug in getUtcBiasHours()
again.
It's just the one line of code, sunwait.cpp:439
... But since there may be changes elsewhere in the code, I need to re-test it all. (With DST, that means testing on a device where I can change the system clock without concern. 😉)
Hello Mr. Risacher, and welcome back!
Back in 2015, someone forked your project on Github here: https://github.com/klada/sunwait
Since this new maintainer was more responsive at the time, I submitted to him my DST bug fix from 2018. I also recommended a change of upstream to the maintainers of Macports: https://trac.macports.org/ticket/57657
I suppose we should compare the best changes across both repos and settle on an authoritative maintainer again?
If that's you, we should tell the Macports people again.
Thanks!