risc0 / risc0-ethereum

Integration of the RISC Zero verifiable compute platform with Ethereum and EVM chains.
https://risczero.com
Apache License 2.0
60 stars 15 forks source link

[BUG] groth16::encode takes a owned Vec<u8> when it could take a slice #174

Closed mothran closed 3 weeks ago

mothran commented 2 months ago

Bug Report

https://github.com/risc0/risc0-ethereum/blob/main/contracts/src/groth16.rs#L25

In the groth16::encode() method it would be nice if the seal param was a slice instead of a Vec so I could avoid a clone pulling the seal from a receipt.

nategraf commented 3 weeks ago

Closed by https://github.com/risc0/risc0-ethereum/pull/179