search

risc0 / risc0-foundry-template

Template for integrating RISC Zero and Ethereum using Foundry
https://risczero.com
92 stars 55 forks source link

Add murky to remappings #86

Closed capossele closed 6 months ago

capossele commented 7 months ago

As far as I've understood, remappings of risc0-ethereum should be replicated to the foundry template as well, so murky has been added to that.

Closes https://github.com/risc0/risc0-ethereum/issues/25

capossele commented 7 months ago

@Cardosaum can you confirm that this fixes your issues?

nategraf commented 6 months ago

I hit a similar issue I think, with the root cause for me being that I only shallow clones the submodules.

Cardosaum commented 6 months ago

Unfortunately, it does not fix all remapping issues, as even with murky itself I'm getting broken dependencies. It seems to me that remappings from risc0-ethereum interfere with remappings in the template, I'm not exactly sure what is happening yet.

Cardosaum commented 6 months ago

Based on a call we had yesterday, seems like this change does solve one of the issues we had with remappings.txt. We still have some compilation errors, but they're derived from other things.