Closed austinabell closed 1 year ago
We actually kinda use async for RPC calls, but then we do block_on to make it blocking
Oh, I did definitely skim over that detail, I didn't see the provider nested in the get_initial_data
call. My alternate suggestion in the diff is obviously not valid then, I did not expect that :D
I was skimming code and noticed this. Doesn't matter now since nothing is being executed async (didn't look in depth), but it is a good future proof if there is in order not to block the executor.
Alternatively, since it seems like nothing needs to be async, this could be done to remove the runtime until it's needed:
I'm assuming this was made to be async because maybe there is a plan to change the bonsai HTTP calls to async or have more logic be handled in parallel in the future, which is why I suggested the change I PRed.
Feel free to close; this change doesn't matter right now. I just figured I'd point it out!