risc0 / zeth

A "Type 0" zkEVM. Prove validity of Ethereum blocks using RISC Zero's zkVM
Apache License 2.0
382 stars 68 forks source link

The CI doesn't trigger the Clippy action #67

Open dyxushuai opened 11 months ago

dyxushuai commented 11 months ago

Independent issue for tracking the CI problem. The original discussion: https://github.com/risc0/zeth/pull/64#pullrequestreview-1775562186

My opinion: https://github.com/risc0/zeth/pull/64#issuecomment-1851969881

I think it doesn't add Clippy component in the risc0/risc0/.github/actions/rustup action. Perhaps we can add the snippet:

with:
    components: clippy
  clippy:
    name: clippy
    runs-on: ubuntu-latest
    timeout-minutes: 30
    steps:
    - uses: actions/checkout@v3
      with:
        submodules: recursive
    - uses: risc0/risc0/.github/actions/rustup@release-0.18
      with:
        components: clippy
    - uses: risc0/risc0/.github/actions/sccache@release-0.18
    - uses: risc0/clippy-action@main
      with:
        reporter: 'github-pr-check'
        fail_on_error: true
        github_token: ${{ secrets.GITHUB_TOKEN }}
        clippy_flags: --workspace --all-targets --all-features -- -Dwarnings
Wollac commented 11 months ago

In general, the CI triggers reviewdog [clippy] (e.g. https://github.com/risc0/zeth/runs/19521165223). However, it seems to depend on the module 🤔 Maybe it is related to the fact that clippy does not work from the command line...

dyxushuai commented 11 months ago

In general, the the CI triggers reviewdog [clippy] (e.g. risc0/zeth/runs/19521165223). However, it seems to depend on the module 🤔 Maybe it is related to the fact that clippy does not work from the command line...

I got lots of context from you. I want to give the issue a try in the coming days.