search

risc0 / zeth

A "Type 0" zkEVM. Prove validity of Ethereum blocks using RISC Zero's zkVM
Apache License 2.0
381 stars 68 forks source link

feat: enable CI for pull request #77

Open dyxushuai opened 10 months ago

dyxushuai commented 10 months ago

Related #75 #76 +r @Wollac

flaub commented 10 months ago

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

dyxushuai commented 10 months ago

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Related to this pr https://github.com/risc0/zeth/pull/75#issuecomment-1896273565

dyxushuai commented 10 months ago

I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions.

dyxushuai commented 10 months ago

Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions.

FYI, https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

flaub commented 10 months ago

If we want to start enforcing a style on these files, then we need to have a CI check to ensure that the file can't be landed in a bad style.

dyxushuai commented 10 months ago

good idea, using CI lints CI file, haha

dyxushuai commented 10 months ago

good idea, using CI lints CI file, haha

@flaub I added yamllint for CI files and tested it locally. It worked as expected.