riscv-admin / dev-partners

This repo is for tracking of RISC-V Development Partners Activities
3 stars 0 forks source link

Virtual Memory ACT #11

Open jjscheel opened 1 year ago

jjscheel commented 1 year ago

Technical Group

Privileged Spec IC

ratification-pkg

Virtual Memory

Technical Liaison

Dan Lustig, Andrea Mondelli

Task Category

Arch Tests

Task Sub Category

Ratification Target

4Q2021

Statement of Work (SOW)

SOW: link

SOW Signoffs: (delete those not needed)

Waiver

Pull Request Details

jjscheel commented 1 year ago

Status from Umer:

VM ACTs: Tests are getting developed under supervision of Allen. PR is expected in the next month hopefully.

UmerShahidengr commented 1 year ago

Update Apr 25th, 2023 => The Trap handler PR has been merged successfully. It has removed all known bugs related to VM and ePMP trap. The PR details are here Next week task => Complete macro definitions to setup page tables for SV39 and SV32, and start developing the tests according to the developed test plan

jjscheel commented 1 year ago

Update from Allen:

  1. Got the next version of the trap handler working and tested (With help for 10xe folks) and merged. It is now possible to write tests of virtual memory, transition between protections mode easily, and write tests that can partition > permissions inside test code and data.
  2. continue to partition and Test Format Spec into ACT Developer Spec and ACT User Spec, and continue to get new chair up to speed
  3. no
  4. I don't have any dates....
jjscheel commented 1 year ago

My sense is that this work won't be done by next meeting on May 9. So, let's try a target of May 23.

@UmerShahidengr, thoughts?

UmerShahidengr commented 1 year ago

I couldn't understand what do you mean by "done" here. For this week's target, the macros for SV39 and SV32 have been updated, so there are no unresolved dependencies in writing ACTs for VM (for now). Some of the baseline tests are available here, but they are not ready for the PR yet. We are testing it through Sail log, and not putting anything in the signature file yet. I hope these tests will be updated in this week and some of the new tests will also be added for SV32. But this project is still a long way away from completion (if you are calling completion as "done") as there are so many test and corner cases to cover but we will try to do our first PR during the next week.

jjscheel commented 1 year ago

@UmerShahidengr, great question. I should have been more specific.

I was asking when the PR would be submitted and accepted, i.e. "done with the all work". Do you have a target here?

UmerShahidengr commented 1 year ago

Progress Update May 7th, 2023 => Still working on defining the macros for SV39 page table setup. Next Week goal => Develop basic tests for SV32 (RV32) and make the first PR.

In regards to the question of @jjscheel , our initial deadline for completing this work was 2023Q2 but it will take more time. @Abdulwadoodd can you comment on any target deadline?

UmerShahidengr commented 1 year ago

Update May 23rd, 2023 => Not much update on this task yet.

jjscheel commented 1 year ago

Thanks, @UmerShahidengr. Removed from today's agenda. Touch base next meeting.

@Abdulwadoodd , do you have a target completion date for all work?

UmerShahidengr commented 1 year ago

Update ⇾ June 12th, 2023: @Abdulwadoodd is busy in client's project, so we have been searching for a helping hand within 10xE who will help him in this project. Sa far, there is not much update in this.

jjscheel commented 1 year ago

No worries. We can just let this sit at the time being. Thanks for update.

jjscheel commented 1 year ago

Marking as "Blocked" due to current constraints identified.

UmerShahidengr commented 1 year ago

Update ⇾ July 11th, 2023 No update.

jjscheel commented 1 year ago

Any outlook for being able to make progress here? Just wondering.

UmerShahidengr commented 11 months ago

Update ⇾ August 15th, 2023 This task was given to some undergraduate students as summer project, and those students have developed some good tests, draft tests are available here. I will optimize these tests and will make a PR before the next meeting. Review process will start from this week, so we can expect it to be merged in this quarter hopefully.

UmerShahidengr commented 10 months ago

Update ⇾ September 12th, 2023 The tests have been submitted in riscv-arch-test repo here. Switched the progress status to review.

jjscheel commented 10 months ago

Thanks, @UmerShahidengr. I've added the new PR to the first entry.

Question on the new PR, do we believe this is the final PR for the work?

UmerShahidengr commented 10 months ago

@jjscheel yes. This is the final PR. It contains all tests for SV32 mode.

jjscheel commented 10 months ago

As discussed today, more PRs are needed for Sv39, and Sv57 modes.

UmerShahidengr commented 10 months ago

Update ⇾ September 26th, 2023 Nobody has started reviewing SV32 tests yet. So, no update on this. SV39 and SV48 PRs are expected before the next meeting.

UmerShahidengr commented 9 months ago

Update ⇾ October 10th, 2023 All PRs have been submitted, here are the details of all PRs: SV32: https://github.com/riscv-non-isa/riscv-arch-test/pull/382 SV39: https://github.com/riscv-non-isa/riscv-arch-test/pull/392 SV48: https://github.com/riscv-non-isa/riscv-arch-test/pull/393

Just review is left now

UmerShahidengr commented 9 months ago

Update ⇾ October 24th, 2023 Coverpoint definitions are in process

UmerShahidengr commented 8 months ago

Update Nov 3rd, 2023:

UmerShahidengr commented 8 months ago

Update ⇾ November 28th, 2023 The coverpoint definitions are yet to be reviewed by Allen, it will be reviewed by this Friday, hopefully we will have un update till next week

UmerShahidengr commented 7 months ago

Update ⇾ December 12th, 2023 The review process is going on smoothly.

UmerShahidengr commented 5 months ago

Update ⇾ January 30th, 2024 The review process is going on.

UmerShahidengr commented 4 months ago

Update ⇾ March 5th, 2024 Stalled.

jjscheel commented 4 months ago

@UmerShahidengr, is this stalled in the community? If so, is it all pieces or some?

@allenjbaum, FYI.

UmerShahidengr commented 4 months ago

It is not stalled in the community, it is stalled from our side. After converting the coverpoints of PMP, @MuhammadHammad001 will translate VM coverpoints according to the new template too.

UmerShahidengr commented 3 months ago

Update ⇾ April 2nd, 2024 Stalled from our side. Coverpoint definitions will be resumed once PMP is done

jjscheel commented 3 months ago

Thanks for the update @UmerShahidengr. Please let us know when @MuhammadHammad001 starts his work on coverpoints.

UmerShahidengr commented 2 months ago

Update April 30th, 2024: Since pmp work is complete from our side, @MuhammadHammad001 has been working on sv32 coverpoints which will be delivered before the next meeting

UmerShahidengr commented 1 month ago

Update June 11th, 2024: @MuhammadHammad001 has been working on this one in parallel with PMP.

jjscheel commented 1 month ago

@UmerShahidengr, what is the status of the sv32 coverpoints? What remains to be completed?

UmerShahidengr commented 1 month ago

@jjscheel we have been targeting this quarter to complete these coverpoints, @MuhammadHammad001 has been working on this one.

jjscheel commented 1 month ago

Thanks. Does "this quarter" mean by end of June (2 weeks) or in the next 90 days?

UmerShahidengr commented 1 month ago

Our plan was to conclude it in this quarter means by the end of June but I doubt it will take some more time

UmerShahidengr commented 1 month ago

Update June 25th, 2024 @MuhammadHammad001 has been working on this one, the work is in progress for sv32 coverpoints.

UmerShahidengr commented 4 days ago

Update July 23rd, 2024: @MuhammadHammad001 will be unavailable for next few weeks due to medical emergency in his family. This work will be resumed after the next month.

jjscheel commented 4 days ago

I'm sorry to hear that. Thanks for the update.