riscv-admin / dev-partners

This repo is for tracking of RISC-V Development Partners Activities
3 stars 0 forks source link

Zfinx ACT #17

Open jjscheel opened 1 year ago

jjscheel commented 1 year ago

Technical Group

Unprivileged Spec IC

ratification-pkg

Zfinx

Technical Liaison

Tariq Kurd

Task Category

Arch Tests

Task Sub Category

Ratification Target

4Q2021

Statement of Work (SOW)

SOW: link

SOW Signoffs: (delete those not needed)

Waiver

Pull Request Details

jjscheel commented 1 year ago

Per email from Prasanna on 4/11:

Zfinix and Zfh : Scheduled a call tomorrow to discuss on the possible solution with respect to sign extension of Zfinix in RV64 (One of the comment provided) - In progress

ptprasanna commented 1 year ago

Having few challenges in implementing the sign prefix for Zfinx, the change has to be inline with the model that we use. Planning to run the test against spike to see the results if it is different than sail.

ptprasanna commented 1 year ago

keeping up the same work as before, continuing to progress on the test run to increase the coverage percentage achieved.

jjscheel commented 1 year ago

Thanks, @ptprasanna! Any chance you could report coverage percentage as we progress?

ptprasanna commented 1 year ago

Completed with the tests and coverage run. Have sent the tests for peer review before raising the PR.

jjscheel commented 1 year ago

Great new, @ptprasanna! Fingers crossed.

ptprasanna commented 1 year ago

@jjscheel - Please change the PR to be as below

https://github.com/riscv-non-isa/riscv-arch-test/pull/367 https://github.com/riscv-software-src/riscv-ctg/pull/67 https://github.com/riscv-software-src/riscv-isac/pull/72

jjscheel commented 1 year ago

Updated. Thank you!

ptprasanna commented 1 year ago

All the Comments that were provided are incorporated, and awaiting PR approval and merge..!

anuani21 commented 1 year ago

Decoded using rvopcodesdecoder and placed the report in the below link

https://gitlab.com/ptprasanna/actreports/-/tree/main/RV64Zfinx?ref_type=heads

jjscheel commented 1 year ago

Sounds like we are close! THANKS.

jjscheel commented 9 months ago

@ptprasanna, I would like an update in the issue, by the next meeting on December 12, 2023, please.

jjscheel commented 8 months ago

Per @anuani21 in #20:

Zfinx and Zfh PR for ISAC has been merged. https://github.com/riscv-software-src/riscv-isac/pull/72

Zfinx and Zfh PR from CTG has been waiting for review. https://github.com/riscv-software-src/riscv-ctg/pull/67

anuani21 commented 7 months ago

Zfinx and Zfh PR from CTG has been waiting for review. https://github.com/riscv-software-src/riscv-ctg/pull/67

anuani21 commented 5 months ago

@jjscheel,

Zfinx and Zfh PR for ISAC has been merged. https://github.com/riscv-software-src/riscv-isac/pull/72

Zfinx and Zfh PR in arch-test suite has been merged. https://github.com/riscv-non-isa/riscv-arch-test/pull/367

Only Zfinx and Zfh PR from CTG has been waiting for approval by Neel. https://github.com/riscv-software-src/riscv-ctg/pull/67

jjscheel commented 5 months ago

Thanks, @anuani21. Understand.

@allenjbaum, here is where the work is needed.

anuani21 commented 5 months ago

@jjscheel,

Zfinx and Zfh PR from CTG still waiting for approval. https://github.com/riscv-software-src/riscv-ctg/pull/67

jjscheel commented 5 months ago

@allenjbaum and @anuani21, I'm inclined to simply mark this as Blocked and leave it for the community to pick up. It's not fair to IITM to ask them to continue working/watching something that hasn't moved in almost 9 months.

anuani21 commented 5 months ago

I will try to make merge riscv-ctg PR as soon as possible

On Tue, 16 Apr, 2024, 6:27 pm Jeff Scheel, @.***> wrote:

@allenjbaum https://github.com/allenjbaum and @anuani21 https://github.com/anuani21, I'm inclined to simply mark this as Blocked and leave it for the community to pick up. It's not fair to IITM to ask them to continue working/watching something that hasn't moved in almost 9 months.

— Reply to this email directly, view it on GitHub https://github.com/riscv-admin/dev-partners/issues/17#issuecomment-2059030733, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3G6FF3FFA3ZLLQGYYWOSJTY5UN4TAVCNFSM6AAAAAAV6RUI6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGAZTANZTGM . You are receiving this because you were mentioned.Message ID: @.***>

jjscheel commented 5 months ago

Thanks, @anuani21. Please work with Arch Test SIG and @allenjbaum to see if it can be merged. If they still cannot find people to review it, I propose we simply leave it there until the community becomes active again.

jjscheel commented 4 months ago

@anuani21, any new status here?

anuani21 commented 2 weeks ago

@jjscheel,

All PR in riscv-ctg,riscv-isac and riscv-arch-test are merged for Zfh and Zfinx.

jjscheel commented 18 hours ago

@allenjbaum, can you kindly review the work here and signoff on its completion? A simple approval comment will suffice.