Zce gcc, binutils

[jjscheel]

Technical Group

Code Size Reduction TG

ratification-pkg

Code Size

Technical Liaison

Tariq Kurd

Task Category

Compilers/Toolchain

Task Sub Category

• [X] gcc
• [X] binutils
• [ ] gdb
• [ ] intrinsics
• [ ] Java
• [ ] KVM
• [ ] ld
• [ ] llvm
• [ ] Linux kernel
• [ ] QEMU
• [ ] Spike

Ratification Target

1Q2023

Statement of Work (SOW)

SOW link

SOW Signoffs: (delete those not needed)

• Task group liaison sign-off date:
• Development partner sign-off date:
• Toolchains & Runtimes sign-off date (if gcc, LLVM, binutils, gdb work):

Waiver

• [ ] Freeze
• [ ] Ratification

Pull Request Details

• Zcmp patch
• Zcmt patch, updated

[jjscheel]

Patches remain in review per 3/28 meeting. No action needed.

[pz9115]

The patch is still in review, so let's wait a moment for Kito to review it :)

https://gcc.gnu.org/pipermail/gcc-patches/2023-April/615287.html

[jjscheel]

Ok, @pz9115. Yes, I understand that Kito is very busy with RVV Intrinsic work!

[pz9115]

Kito plan to finish this in gcc 14:

https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616266.html https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616267.html

[kito-cheng]

@pz9115 let you know I'll take a close review this week.

[pz9115]

Thank you very much :)

[jjscheel]

@pz9115, please share your status on which patches are nearing completion and which are needing rework. Thanks!

[pz9115]

I got serveral suggestions for the gcc patches and now discussing in zcmp extension implement.

[jjscheel]

Thanks, @pz9115!

[pz9115]

ESWIN helped us to optimize the zcmp patches recently, it still work in progress.

[jjscheel]

Ok, thanks, @pz9115.

Removing from agenda for another couple weeks.

[pz9115]

Resend gcc patch and binutils patch to upstream, Eswin help optimal the zcmp extension implement. Plan to sync-up two weeks later :)

[pz9115]

Zca/f/d/b extensions patch were merged, zcmp/t patches are preparing.

[pz9115]

You can find a total implement version in this issue: https://github.com/riscv-collab/riscv-gnu-toolchain/issues/1288

[pz9115]

Sever Binutils patch merged into upstream, Zcmp/Zcmt is still work in progress.

https://gcc.gnu.org/git?p=gcc.git;a=commit;h=7879f589af911ea6a910d08919014b0b2df1b4b1 https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=899748950c12ee446bb394bb9660da1034bfbdc9

[jjscheel]

@pz9115, thanks for the update. Can we now claim that all Zc binutils work is upstream?

[jjscheel]

@pz9115, what progress did we make on Zcmp/Zcmt patch merge?

[pz9115]

We still work on Zcmp/t implement in Binutils, and some gcc Zcmp patches merged into upstream in the past two weeks, and some discuss for Binutils Zc changes record in https://github.com/riscv-non-isa/riscv-asm-manual/issues/91

[pz9115]

WIP，will resend binutils patches recently.

[pz9115]

Discussed in the last RISC-V GNU toolchain meeting, WIP.

[pz9115]

Resent patches to upstream, status change to in review https://sourceware.org/pipermail/binutils/2023-November/130690.html https://sourceware.org/pipermail/binutils/2023-November/130691.html

[pz9115]

Also updated the Zcmt extension patch: https://sourceware.org/pipermail/binutils/2023-November/130849.html

[pz9115]

Waiting for review yet.

[pz9115]

Receive Kito's review comments and now modify the patch, prepare to resend them within this week.

[pz9115]

Receive more comments from Kito to option the patch:

https://sourceware.org/pipermail/binutils/2024-January/131575.html

https://sourceware.org/pipermail/binutils/2024-January/132145.html

Resend fifth version of patch, keep reviewing:

ZCMP: https://sourceware.org/pipermail/binutils/2024-January/132237.html

[pz9115]

Received new comments from Kito, WIP.

[pz9115]

Resent new patch in last week, waiting for review: https://sourceware.org/pipermail/binutils/2024-February/132675.html

[pz9115]

Still waiting for review and comments.

[pz9115]

Will resend new patches this week.

[pz9115]

Zcmp patch merged into Binutils upstream, now working on Zcmt part.

https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9132c8152b899a1683bc886f8ba76bedadb48aa1

[jjscheel]

Nice work, @pz9115! I've added your patch to the description above. Is Zcmt the only other patch needed here?

[pz9115]

Now we only remain Zcmt patch, it needs some linker part changes, still WIP.

[pz9115]

WIP.

[jjscheel]

How much longer before we have a submitted PR for Zcmt, @pz9115?

[pz9115]

How much longer before we have a submitted PR for Zcmt, @pz9115?

I think it will take about two weeks, I will finish this job within this month.

[pz9115]

Resent new patch, waiting for review now, https://sourceware.org/pipermail/binutils/2024-May/134328.html.

[jjscheel]

Thanks, Jiawei. Is this the final Zc* patch?

[pz9115]

Yes, it is, still waiting for reviewing.

[pz9115]

Now new updates in these two weeks.

[pz9115]

No review received.

[pz9115]

Keep waiting...

[jjscheel]

@cmuellner, any suggestions for @pz9115 to get feedback on his patch?

[pz9115]

No new conditions here.

[pz9115]

During the test, my colleague found that two instructions of zcmp were missing. I resubmitted the patch of cm.mv instruction, which has been merged into binutils upstream.

https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ca2590d7804b4ea563eec6f1127ed17a00c30315

Rebasing zcmt patch into binutils 2.43

[pz9115]

Finished rebase works and resent patches to upstream, waiting for reviews.

https://sourceware.org/pipermail/binutils/2024-September/136740.html

[pz9115]

Received Nelson's helpful comments, preparing a new patch. https://sourceware.org/pipermail/binutils/2024-September/136920.html

[pz9115]

Meet some conflict issues, still preparing the new patch.

[pz9115]

Rebased and sent to the mailing list, waiting for review. https://sourceware.org/pipermail/binutils/2024-October/137437.html

[pz9115]

Still waiting for review.