search

riscv-collab / riscv-gnu-toolchain

GNU toolchain for RISC-V, including GCC
Other
3.56k stars 1.17k forks source link

Update DejaGnu? #1573

Closed TommyMurphyTM1234 closed 1 month ago

TommyMurphyTM1234 commented 1 month ago

As far as I can see, riscv-gnu-toolchain uses a very old version of DejaGnu:

git submodule status dejagnu
 ca371cf9c48186716d26c8e10d442affaf002c80 dejagnu (dejagnu_1_4_3-911-gca371cf)

And again. as far as I can see, DejaGnu v1.4.3 dates back to 2002!

Is this correct? If so then surely it's long overdue a bump to a more recent version - maybe the latest version v1.6.5?

However I'm a bit confused by some of the DejaGnu related PRs...

Am I misunderstanding something here?

If it does merit a bump then how can this be tested? I have tried running the test suite on multilib enabled toolchains on my hardware but it takes far too long to be practical. Is there some other and more efficient way to do this - e.g. on some remote/cloud server perhaps?

cmuellner commented 1 month ago

dejagnu_1_4_3-911-gca371cf means tag dejagnu_1_4_3 plus 911 commits on top, which is commit ca371cf from Sat Apr 13 19:36:47 2024.

We cannot roll-back much, because upstream DejaGnu had an issue, which caused fails in RISC-V multilib builds. I think this was fixed last year and once this was done, we switched to upstream DejaGnu. Afaik, there is no release tag upstream that we can use.

Also note, that the recent release tags in DejaGnu are placed on commits that are in release branches. Which is why you see git using dejagnu_1_4_3 as base.

TommyMurphyTM1234 commented 1 month ago

dejagnu_1_4_3-911-gca371cf means tag dejagnu_1_4_3 plus 911 commits on top, which is commit ca371cf from Sat Apr 13 19:36:47 2024.

Ah - thanks for the explanation @cmuellner. I didn't realise that but maybe it's a common convention?

We cannot roll-back much, because upstream DejaGnu had an issue, which caused fails in RISC-V multilib builds. I think this was fixed last year and once this was done, we switched to upstream DejaGnu. Afaik, there is no release tag upstream that we can use.

OK - thanks. I'll close this issue so.