riscv-collab / riscv-gnu-toolchain

GNU toolchain for RISC-V, including GCC
Other
3.56k stars 1.17k forks source link

fix NEWLIB_MULTILIB_NAMES in Makefile #1588

Closed MetaLambda closed 1 month ago

MetaLambda commented 1 month ago

The NEWLIB_MULTILIB_NAMES generated in makefile for MULTILIB_GEN may contain space at the end, which cause the generate_target_board script to crash.

MetaLambda commented 1 month ago

see #1513

cmuellner commented 1 month ago

So it looks like we generate useless space characters and fix this later. Could we do something on the other end to prevent the useless space characters from being generated?

MetaLambda commented 1 month ago

ok, I'll try a fix in Makefile.in

MetaLambda commented 1 month ago

@cmuellner I modify the Makefile.in to eliminate the useless space at the end of NEWLIB_MULTILIB_NAMES

cmuellner commented 1 month ago

Merged after the CI showed that all pipelines were fine.

Thanks!

TommyMurphyTM1234 commented 1 month ago

Thanks a lot @MetaLambda! 👍