search

riscv-collab / riscv-gnu-toolchain

GNU toolchain for RISC-V, including GCC
Other
3.56k stars 1.17k forks source link

Update build workflow #1608

Closed mickflemm closed 5 days ago

mickflemm commented 3 weeks ago

This series aims to improve the current build workflow as suggested in #1591.

TommyMurphyTM1234 commented 3 weeks ago

It's better to use ubuntu-latest to track current LTS provided by github, instead of having to manually update it. It also makes more sense to stick to the current LTS than trying to support the older one.

I thought that it was a deliberate decision to build for the most recent two LTS versions of Ubuntu? E.g.:

I'm not objecting to the switch to just ubuntu-latest but just pointing this out in case it's important.

mickflemm commented 3 weeks ago

It's better to use ubuntu-latest to track current LTS provided by github, instead of having to manually update it. It also makes more sense to stick to the current LTS than trying to support the older one.

I thought that it was a deliberate decision to build for the most recent two LTS versions of Ubuntu? E.g.:

* [CI: Drop Ubuntu 20.04 and add Ubuntu 24.04 #1570](https://github.com/riscv-collab/riscv-gnu-toolchain/pull/1570)

* [Switch from Ubuntu 20.04 LTS to 22.04 LTS for jobs #1353](https://github.com/riscv-collab/riscv-gnu-toolchain/pull/1353)

I'm not objecting to the switch to just ubuntu-latest but just pointing this out in case it's important.

From both examples it seems this approach doesn't work well, things break since the repos used here are much more recent than the older ubuntu LTS, and sometimes their build process depends on recent tools and libraries, that are either not present on the older LTS or behave differently. The current build workflow already has exceptions for the older LTS, test-sim is only built for the current LTS, and make report also works only on current LTS.

I think it's better to just stick to the current LTS, and even use the ubuntu-latest label so that we don't need to update the yaml files with ubuntu version numbers everytime we get a new LTS.

TommyMurphyTM1234 commented 3 weeks ago

Thanks @mickflemm, I'm fine with that but just wondered if dropping the "two most recent LTS versions" approach might have unintended consequences. Maybe @cmuellner might know and/or be able to sign off on this change?

mickflemm commented 3 weeks ago

I'll do some more tests and then update the night release script as well to also do caching etc...

kito-cheng commented 5 days ago

I see the only controversial point has gone - the ubuntu version stuffs, so I am happy to moving this forward :)

kito-cheng commented 5 days ago

@mickflemm thank you!!!

mickflemm commented 5 days ago

Thanks @kito-cheng !