search

riscv-collab / v8

Port of Google v8 engine to RISC-V.
https://github.com/v8-riscv/v8/wiki
Other
237 stars 31 forks source link

wasm i64 oprator need Pair macro #644

Closed luyahan closed 2 years ago

luyahan commented 2 years ago

testcase

=== cctest/test-js-to-wasm/TestFastJSWasmCall_I64NegativeResult ===           
=== cctest/test-js-to-wasm/TestFastJSWasmCall_I64ArgExpectsBigInt ===         
=== cctest/test-js-to-wasm/TestFastJSWasmCall_LazyDeopt_I64Result ===         
=== cctest/test-js-to-wasm/TestFastJSWasmCall_I64Arg ===                      
=== cctest/test-js-to-wasm/TestFastJSWasmCall_MixedArgs ===                   
=== cctest/test-js-to-wasm/TestFastJSWasmCall_MixedMistypedArgs ===           
=== cctest/test-run-wasm-memory64/RunWasmLiftoff_MemoryGrow ===               
=== cctest/test-run-wasm/RunWasmLiftoff_I64DivSOnDifferentRegisters ===       
=== cctest/test-run-wasm/RunWasmLiftoff_I64AddOnDifferentRegisters ===        
=== cctest/test-run-wasm/RunWasmLiftoff_I64DivUOnDifferentRegisters ===       
=== cctest/test-run-wasm/RunWasmLiftoff_I64RemSOnDifferentRegisters ===       
=== cctest/test-run-wasm/RunWasmLiftoff_I64MulOnDifferentRegisters ===        
=== cctest/test-run-wasm/RunWasmLiftoff_I64ShrUOnDifferentRegisters ===       
=== cctest/test-run-wasm/RunWasmLiftoff_I64RemUOnDifferentRegisters ===       
=== cctest/test-run-wasm/RunWasmLiftoff_I64ShlOnDifferentRegisters ===        
=== cctest/test-run-wasm/RunWasmLiftoff_I64SubOnDifferentRegisters ===        
=== cctest/test-run-wasm/RunWasmLiftoff_I64ShrSOnDifferentRegisters ===       
=== cctest/test-wasm-breakpoints/RunWasmLiftoff_WasmGetLocalsAndStack ===     
=== cctest/test-wasm-breakpoints/RunWasmTurbofan_WasmGetLocalsAndStack ===
AlviseDeFaveri commented 2 years ago

Related to #648 I guess?

luyahan commented 2 years ago

Related to #648 I guess?

yes

luyahan commented 2 years ago

619

AlviseDeFaveri commented 2 years ago

Started to solve these in this commit

The following tests are still failing:

cctest/test-run-wasm/RunWasmLiftoff_I64MulOnDifferentRegisters 
cctest/test-run-wasm/RunWasmLiftoff_I64ShrUOnDifferentRegisters
cctest/test-run-wasm/RunWasmLiftoff_I64ShlOnDifferentRegisters 
cctest/test-run-wasm/RunWasmLiftoff_I64ShrSOnDifferentRegisters
luyahan commented 2 years ago

Started to solve these in this commit

The following tests are still failing:

cctest/test-run-wasm/RunWasmLiftoff_I64MulOnDifferentRegisters 
cctest/test-run-wasm/RunWasmLiftoff_I64ShrUOnDifferentRegisters
cctest/test-run-wasm/RunWasmLiftoff_I64ShlOnDifferentRegisters 
cctest/test-run-wasm/RunWasmLiftoff_I64ShrSOnDifferentRegisters

i had fixed it

AlviseDeFaveri commented 2 years ago

Ah nice! Can you point me to the commit? I'm curious about what was the problem