riscv-forks / electron

[WIP] electron for riscv64
https://electronjs.org
5 stars 3 forks source link

SIGILL on rdcycle, which becomes a privileged instruction since linux 6.6 #2

Closed kxxt closed 3 months ago

kxxt commented 3 months ago

All rdcycle usage should be replaced/removed from the codebase.

kxxt commented 3 months ago

For abseil-cpp, it's already fixed in main branch of chromium's vendored copy: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/abseil-cpp/absl/base/internal/unscaledcycleclock.cc by 03b48d871136a25321821618e5b2544ee8dec4b0 https://chromium-review.googlesource.com/c/chromium/src/+/5404980

It's introduced into chromium in 115290d7e28203c9275c89cc301271ba56157e48 https://chromium-review.googlesource.com/c/chromium/src/+/3161995

I still need to determine which electron versions are affected.

kxxt commented 3 months ago

chromium [96.0.4644.0, 125.0.6395.0) is affected, which corresponds to electron [18, 30].

electron 31 is not affected.

electron 29 and 30 will be fixed.

If anyone need support for EOL electron versions(26, 27, 28), please leave a comment here.

kxxt commented 3 months ago

./../../third_party/abseil-cpp/absl/base/internal/unscaledcycleclock.cc:128 is fixed in

kxxt commented 3 months ago

Closing as the absl one is the only real world usage found.