[Qualcomm feedback] Chapter 9.11 onwards (fix ABI errors)

riscv-non-isa / riscv-ap-tee

This repo holds the work area and revisions of the non-ISA specification created by the RISC-V AP-TEE TG. This specification defines the programming interfaces (ABI) to support the Confidential VM Extension (CoVE) confidential computing architecture for RISC-V application-processor platforms.

https://jira.riscv.org/browse/RVG-76

Creative Commons Attribution 4.0 International

49 stars 19 forks source link

[Qualcomm feedback] Chapter 9.11 onwards (fix ABI errors) #65

Closed rsahita closed 6 months ago

rsahita commented 7 months ago

Reference: link

sbi_covh_add_tvm_page_table_pages

tsm_page_type is not passed as parameter. Missing?

Copies num_pages pages from non-confidential memory

fix num_pages markup style in 9.11 9.13 and 9.14

sbi_covh_add_tvm_measured_pages

tvm_guest_gpa missing as potentially invalid address.

sbi_covh_create_tvm_vcpu

Error code missing for cases where input requirements are not met by tvm_stage_page_addr param.

9.16 "0"

should be SBI_SUCCESS (fix error code in table to SBI_SUCCESS)

rsahita commented 6 months ago

Fixed in #66 @osman-koyuncu-qualcomm @atishp04

ozkoyuncu commented 6 months ago

@rsahita ack. for some reason I don't get the tag notification

eckhard-delfs-qualcomm commented 6 months ago

@ozkoyuncu : Testing github notification / Please ignore.

rsahita commented 6 months ago

addressed in #66