riscv-non-isa / riscv-arch-test

https://jira.riscv.org/browse/RVG-141?src=confmacro
Apache License 2.0
514 stars 199 forks source link

No c.flw or c.fsw in compressed testcases #289

Open ssecatch-w opened 2 years ago

ssecatch-w commented 2 years ago

The floating point directories don't have any compressed instructions and the compressed directories don't have any floating point instructions, so the compressed floating point loads and stores aren't currently covered.

From 16.1 Overview: " If the C extension is implemented, the appropriate compressed floating-point load and store instructions must be provided whenever the relevant standard floating-point extension (F and/or D) is also implemented."

allenjbaum commented 2 years ago

Hmm, as far as I can tell, that is may be because there is a missing support in Sail.

On Tue, Oct 11, 2022 at 10:55 AM ssecatchseagate @.***> wrote:

The floating point directories don't have any compressed instructions and the compressed directories don't have any floating point instructions, so the compressed floating point loads and stores aren't currently covered.

From 16.1 Overview: " If the C extension is implemented, the appropriate compressed floating-point load and store instructions must be provided whenever the relevant standard floating-point extension (F and/or D) is also implemented."

— Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-arch-test/issues/289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPXVJXREXGGJVGX47ZWXKTWCWSZNANCNFSM6AAAAAARCQ3ZKY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

allenjbaum commented 2 years ago

No, the support is in Sail; it appears that it was overlooked because it is shared by both F and C, and it looks like each group thought it was being dealt by the other.

neelgala commented 1 year ago

need a new set of coverpoints to get this up.

davidharrishmc commented 1 year ago

To be precise, the following compressed floating-point loads and stores are not yet tested.

c.flw, c.flwsp, c.fsw, c.fswsp, c.fld, c.fldsp, c.fsd, and c.fsdwp

UmerShahidengr commented 1 year ago

It has been a point of discussion for quite some time now. Even since these compressed instructions are categorised into different extensions (like Zca, Zcb, Zcf etc.). Its Sail support and ACTs are in development phase and still pending. This SoW (to provide Zc* extension support and its ACTs) was assigned to IITM at DevPartners.

jjscheel commented 7 months ago

@ssecatch-w, Umer is correct that the work is being done by IITM. The DevPartners issue #6. This work is not yet done, but has recently begun being driven again by Anusha (@anuani21).

Please read the issue for status and then reach out to Anusha and ensure that everything is being addressed or will be addressed.