search

riscv-non-isa / riscv-arch-test

https://jira.riscv.org/browse/RVG-141?src=confmacro
Apache License 2.0
500 stars 190 forks source link

Floating point tests are enormous #443

Closed Timmmm closed 6 months ago

Timmmm commented 6 months ago

Some of the floating point tests, e.g. riscv-test-suite/rv32i_m/D/src/fmadd.d_b1-01.S are enormous, and take a very long time to run in simulation, and a huge amount of memory to compile.

It would be great if they could be split into a larger number of smaller tests.

Is there any documentation for the process of regenerating the tests?

allenjbaum commented 6 months ago

This is a duplicate of an existing issue, and we will get around to it when someone has the resourcxes. The tests will probably need to take a week just to regenerate, and we need to augment CTG with a size limit, unless someone is clever enough figure out how to split them at the source level.

On Thu, Mar 14, 2024 at 3:00 AM Tim Hutt @.***> wrote:

Some of the floating point tests, e.g. riscv-test-suite/rv32i_m/D/src/fmadd.d_b1-01.S are enormous, and take a very long time to run in simulation, and a huge amount of memory to compile.

It would be great if they could be split into a larger number of smaller tests.

Is there any documentation for the process of regenerating the tests?

— Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-arch-test/issues/443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPXVJRTO7W3HFLXOYPMVY3YYFYKBAVCNFSM6AAAAABEVYRAMKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DKOJTGM3TOOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Timmmm commented 6 months ago

Ah yes I didn't find it when I searched but I did a more extensive search: #307

Is there any documentation for how to regenerate them?

allenjbaum commented 6 months ago

Regeneration is the same as generation, like any other extension. But, CTG will need to be updated to split the test generation up once it has hit certain limits, and ISAC might need updates to accumulate the coverage from all the split pieces, so it isn't going to happen quickly (unless we can get an intern or dev partner to do it

On Fri, Mar 15, 2024 at 2:35 AM Tim Hutt @.***> wrote:

Ah yes I didn't find it when I searched but I did a more extensive search:

307 https://github.com/riscv-non-isa/riscv-arch-test/issues/307

Is there any documentation for how to regenerate them?

— Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-arch-test/issues/443#issuecomment-1999269339, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPXVJVISHVQGBT2UXNRFOTYYK6ELAVCNFSM6AAAAABEVYRAMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGI3DSMZTHE . You are receiving this because you commented.Message ID: @.***>

Timmmm commented 5 months ago

Is there any documentation for this generation process? I might do it if it isn't too onerous, but I can't see any documentation for how the existing tests were generated. Do you have any links or scripts? Is it done in CI somewhere?