riscv-non-isa / riscv-asm-manual

RISC-V Assembly Programmer's Manual
https://jira.riscv.org/browse/RVG-4
Creative Commons Attribution 4.0 International
1.44k stars 238 forks source link

Fix bug #15

Closed mkx171217 closed 6 years ago

mkx171217 commented 6 years ago
  1. using register a0 to pass argument to function puts, not register a1.
  2. "jalr ra, puts" would generate a compile error. Shoule be "jal puts" or "jal ra, puts".
mkx171217 commented 6 years ago

n/a

aswaterman commented 6 years ago

Thanks - this looks correct to me. I’ll merge now, but would appreciate an ex post facto sanity check from @palmer-dabbelt

palmer-dabbelt commented 6 years ago

Yep, the jalr was nonsense -- sorry that slipped through! This should be jal ra, puts, not jal puts, as jal puts is an alias and we're trying to avoid those in the docs.

Thanks!