search

riscv-non-isa / riscv-brs

The Boot and Runtime Services (BRS) specification provides the software requirements for system vendors and Operating System Vendors (OSVs) to interoperate with one another by providing expectations for the Operating System (OS) to utilize in acts of device discovery, system management, and other rich operations provided in this specification.
https://jira.riscv.org/browse/RVG-48
Creative Commons Attribution 4.0 International
42 stars 13 forks source link

Despite claim, no properties are defined in the rscv- namespace #198

Closed jhauser-us closed 1 week ago

jhauser-us commented 2 months ago

Section 6.3, "RVI-specific ACPI Device Properties", says, "This section defines the _DSD device properties in the rscv- namespace." However, the only properties actually mentioned in this section are for UART devices, and if I'm not mistaken, these are not defined in the rscv- namespace. (Right?)

In short, I believe this section says it defines properties in the rscv- namespace but then doesn't do so.

vlsunil commented 1 month ago

You are right. I think this is a place holder for any property to be defined under rscv- namespace. The DSD guide (https://github.com/UEFI/DSD-Guide/blob/main/src/dsd-guide.adoc#appendix-c-known-device-property-prefixes) allows to use vendor ACPI ID as the prefix for the property but vendor needs to manage those properties. For RISC-V, ACPI ID registered is RSCV. Hence, any one in future wants to define and use a new property under rscv- namespace, should register here first. I think that is the idea to have this section.

andreiw commented 3 weeks ago

We had some properties here initially, then - we didn't. Nevertheless, it makes sense to stake a claim to the rscv- namespace now.

andreiw commented 3 weeks ago

Marking this as won't fix given last two comments. If you're okay with that, please close the ticket @jhauser-us.

jhauser-us commented 3 weeks ago

The right response is not to leave the document making an obviously false statement. If you want to stake the claim to the rscv- namespace, then change the text to say that.