search

riscv-non-isa / riscv-c-api-doc

Documentation of the RISC-V C API
https://jira.riscv.org/browse/RVG-4
Creative Commons Attribution 4.0 International
69 stars 39 forks source link

Add pre-defined macro __riscv_p for P extension #26

Closed tclin914 closed 2 years ago

kito-cheng commented 2 years ago

I believe this change is straightforward and no controversy since https://github.com/riscv/riscv-p-spec is there for long time.

cmuellner commented 2 years ago

I'm not a big fan of merging this change, because the P extension is not frozen.

kito-cheng commented 2 years ago

Oh, apology for the rush merge, but I think that's still useful for implementing compiler support for those non-ratified extensions, what do you think if we add few more word to mark that is non-ratified / non-frozen?

cmuellner commented 2 years ago

I would prefer to keep changes for unfrozen extensions as PRs and tag them with "unfrozen extension". Once the extension is frozen, we can merge the change. However, I don't want to overtake the extension ratification process.

My plan is to create a proposal for a merge policy, that we can discuss.

kito-cheng commented 2 years ago

My plan is to create a proposal for a merge policy, that we can discuss.

OK, thanks!

tclin914 commented 2 years ago

Hi @kito-cheng,

Do you plan to revert these changes? I will create a new PR the same as this. It seems merged PR unable to be reopened.