search

riscv-non-isa / riscv-c-api-doc

Documentation of the RISC-V C API
https://jira.riscv.org/browse/RVG-4
Creative Commons Attribution 4.0 International
68 stars 38 forks source link

Add macros for unaligned access #40

Closed vineetgarc closed 1 year ago

vineetgarc commented 1 year ago

The RISC-V ISA spec (and profiles, etc.) appear to consistently use the word "misaligned". Is there a reason this proposal uses "unaligned"?

No real reason, just the terminology I'm more used to from past. I can certainly respin with new verbiage.

kito-cheng commented 1 year ago

cc @asb @luismarques

asb commented 1 year ago

I think from #32, @aswaterman was concerned that _bad was unnecessarily perjorative and _avoid might be preferable.

I had a slight preference for zicclsm even if it's not very comprehensible just to avoid introducing too many ways of saying the same thing. But I don't feel strongly enough to block this. I think we should wait for @aswaterman's feedback though, as he participated in the other thread.

vineetgarc commented 1 year ago

I think from #32, @aswaterman was concerned that _bad was unnecessarily perjorative and _avoid might be preferable.

Fair enough. Updated pull request with bad -> avoid

I had a slight preference for zicclsm even if it's not very comprehensible just to avoid introducing too many ways of saying the same thing.

I tend to disagree still, but we can agree to disagree :-)

But I don't feel strongly enough to block this. I think we should wait for @aswaterman's feedback though, as he participated in the other thread.

Sure thing.

aswaterman commented 1 year ago

I'm OK with this scheme. I guess I agree with @asb in principle, but, like him, I don't think it's actually a problem, so I don't want to hold this up.

asb commented 1 year ago

Thanks Andrew. Sounds like we have consensus on this then? LGTM.

kito-cheng commented 1 year ago

Thanks @vineetgarc , gonna merge this :)