riscv-non-isa / riscv-iommu

RISC-V IOMMU Specification
https://jira.riscv.org/browse/RVG-55
Creative Commons Attribution 4.0 International
98 stars 17 forks source link

remove "PDT" word #279

Closed runninglinuxkernel closed 11 months ago

runninglinuxkernel commented 11 months ago

In chapter 3.1.1,

IOMMU operations cause implicit reads to PDT, first-stage and second-stage page tables. To reduce latency of such reads, the IOMMU may cache entries from the first-stage and/or second-stage page tables in the IOMMU-address-translation-cache (IOATC).

This chapter just talk about invalidate the S1 and S2 page table cache, so for the first sentence, should we remove the word "PDT" avoid confusing?

ved-rivos commented 11 months ago

The paragraph discusses the implicit reads to PDT to draw attention explicitly to the fact that when second-stage is not Bare, the PPNs held in the non-leaf PDT entries and in the pdtp are guest PPNs. They are translated by the second-stage page table to determine the SPA to access the non-leaf PDT entries and the PC. This process could lead to the second-stage address-translation caches being updated.

runninglinuxkernel commented 11 months ago

yes, your explanation is much better than the first sentence of chapter 3.1.1 which is confusing me or other readers.

ved-rivos commented 11 months ago

This has been explained in detail before - e.g. section 2.3.2,

runninglinuxkernel commented 11 months ago

Thanks a lot!