Question about stop marker detect in model when sending prgr

riscv-non-isa / riscv-iommu

RISC-V IOMMU Specification

https://jira.riscv.org/browse/RVG-55

Creative Commons Attribution 4.0 International

72 stars 14 forks source link

Question about stop marker detect in model when sending prgr #337

Closed viktoryou closed 1 month ago

viktoryou commented 1 month ago

From the spec,

"Page request" messages that require a response, i.e. those with "Last Request in PRG" field set to 1 and are not "Stop Marker" messages, may be auto-completed by an IOMMU generated “Page Request Group Response” message as specified in Section 2.7.

In the model, see the code, only "Last Request in PRG" field set to 1 is checked and "Stop Marker" consideration is missing there. I guess this is a bug and please help to check.

ved-rivos commented 1 month ago

Thanks. That was missed and updated in PR #338