search

riscv-non-isa / riscv-rpmi

RISC-V Platform Management Interface Specification. OS-agnostic messaging interface for system management and control
https://jira.riscv.org/browse/RVG-151
Creative Commons Attribution 4.0 International
8 stars 8 forks source link

[REVIEW] Service Group - DEVICE_POWER #14

Closed pathakraul closed 2 weeks ago

yeongjoshua commented 7 months ago

For the services name, can we remove redundant name "DEVICE_POWER" as it belongs to service group with the name.

GET_DEVICE_POWER_DOMAIN_ATTRIBUTES -> GET_NUM_DOMAINS GET_DEVICE_POWER_DOMAIN_ATTRIBUTES -> GET_DOMAIN_ATTRIBUTES SET_DEVICE_POWER_DOMAIN_STATE -> SET_DOMAIN_STATE GET_DEVICE_POWER_DOMAIN_STATE -> GET_DOMAIN_STATE

pathakraul commented 7 months ago

Yes, would you like to submit the PR? Otherwise the service names improvement across the spec is already an AI and due.

yeongjoshua commented 7 months ago

The service 'get fast channel addr' should have another request data of 'service id'. We would not able to obtain whether the respond of fast channel details belongs to get/set level/limit.

lftan commented 4 months ago

The service 'get fast channel addr' should have another request data of 'service id'. We would not able to obtain whether the respond of fast channel details belongs to get/set level/limit.

Fixed in commit https://github.com/riscv-non-isa/riscv-rpmi/commit/7f338d537b27c20f38453a356259e23458fe8f65