search

riscv-non-isa / riscv-trace-spec

RISC-V Processor Trace Specification
https://jira.riscv.org/browse/RVG-88
Creative Commons Attribution 4.0 International
152 stars 47 forks source link

Formatting fixes #101

Closed wmat closed 4 months ago

wmat commented 4 months ago

Fixes issue #100

IainCRobertson commented 4 months ago

Looks good. We will need to republish as 2.0.3. Shouldn't that be part of the same PR?

IainCRobertson commented 4 months ago

Actually, there was a 3rd error related to missing pluses in the definition of the width of the irdepth field that also needs fixing.

wmat commented 4 months ago

Is the 3rd error another looplabel 4 typo?

IainCRobertson commented 4 months ago

No.

return_stack_size_p (return_stack_size_p > 0 ? 1 : 0) call_counter_size_p

should be

return_stack_size_p + (return_stack_size_p > 0 ? 1 : 0) + call_counter_size_p

wmat commented 4 months ago

Fixed.

IainCRobertson commented 4 months ago

Thanks Bill. Do you want to do the revision history and version changes as a separate PR? Not obvious why we should separate them.

wmat commented 4 months ago

Oh right. I can update it here.

IainCRobertson commented 4 months ago

Thanks Bill. Sorry to be a pain but we also need a comment in the revision history table.

IainCRobertson commented 4 months ago

Thanks Bill. I assume you and Jeff will take care of getting this published?

wmat commented 4 months ago

Yep, either I or Jeff will update the Published PDF.