riscv-non-isa / riscv-trace-spec

RISC-V Processor Trace Specification
https://jira.riscv.org/browse/RVG-88
Creative Commons Attribution 4.0 International
152 stars 47 forks source link

Definition of exc_only in figure 9.1 is different from explanation above #127

Closed zhangdujiao closed 2 months ago

zhangdujiao commented 2 months ago

description of exc_only in figure 9.1 only contains exception, and interrupt is not included.

IainCRobertson commented 2 months ago

Yes, that is a minor error in the diagram. When the spec was initially being written, the term "exception" was used to cover both exceptions and interrupts. Later this was replaced with the term "trap". But it looks like this piece of text didn't get updated (likely because it's embedded in a diagram)

Iain

From: zhangdujiao @.> Sent: 28 June 2024 10:20 To: riscv-non-isa/riscv-trace-spec @.> Cc: Subscribed @.***> Subject: [riscv-non-isa/riscv-trace-spec] Definition of exc_only in figure 9.1 is different from explanation above (Issue #127)

description of exc_only in figure 9.1 only contains exception, and interrupt is not included.

- Reply to this email directly, view it on GitHubhttps://github.com/riscv-non-isa/riscv-trace-spec/issues/127, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALQOPSTYCQXFWPEA6ZWH76TZJUTCPAVCNFSM6AAAAABKBPNSCSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TSOJXHA2TANQ. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

zhangdujiao commented 2 months ago

Got it, great to know!