search

riscv-non-isa / riscv-trace-spec

RISC-V Processor Trace Specification
https://jira.riscv.org/browse/RVG-88
Creative Commons Attribution 4.0 International
152 stars 47 forks source link

Does the tval comparison require itype = 1 or 2? #135

Closed zhangdujiao closed 2 weeks ago

zhangdujiao commented 3 weeks ago

When trTeCompPInput codes 2: tval, should the itype =1/2 be added in the if condition, since tval only valid when trap happens. thanks!

IainCRobertson commented 3 weeks ago

Yes, tval should only be compared when itype is 1 or 2.

Iain

From: zhangdujiao @.> Sent: 18 August 2024 07:31 To: riscv-non-isa/riscv-trace-spec @.> Cc: Subscribed @.***> Subject: [riscv-non-isa/riscv-trace-spec] Does the tval comparison require itype = 1 or 2? (Issue #135)

When trTeCompPInput codes 2: tval, should the itype =1/2 be added in the if condition, since tval only valid when trap happens. thanks!

- Reply to this email directly, view it on GitHubhttps://github.com/riscv-non-isa/riscv-trace-spec/issues/135, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALQOPSVRLRDV2MVHWIJTJDDZSA5UDAVCNFSM6AAAAABMWCSMP6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3TCOBRGU3TONA. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

zhangdujiao commented 3 weeks ago

I see, so the itype =1 or 2 should also be added during ecause match in the filter

IainCRobertson commented 3 weeks ago

Yes, absolutely.

Iain

From: zhangdujiao @.> Sent: 19 August 2024 10:03 To: riscv-non-isa/riscv-trace-spec @.> Cc: Robertson, Iain (DI SW ICS DDCP TST RD EAH) @.>; Comment @.> Subject: Re: [riscv-non-isa/riscv-trace-spec] Does the tval comparison require itype = 1 or 2? (Issue #135)

I see, so the itype =1 or 2 should also be added during ecause match in the filter

- Reply to this email directly, view it on GitHubhttps://github.com/riscv-non-isa/riscv-trace-spec/issues/135#issuecomment-2296049028, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALQOPSTAR7IYCQFOYSA5U2TZSGYDFAVCNFSM6AAAAABMWCSMP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGA2DSMBSHA. You are receiving this because you commented.Message ID: @.**@.>>

zhangdujiao commented 3 weeks ago

For trTeFilterMatchChoiceEcauseLow, "When trTeFilterMatchEcause field for filter #i is set, match all excepion causes for which the corresponding bit is set. If bit N is 1, then match if the ecause is N." Does the "all excepion causes" means only exceptions? or both excep. and int. ?

zhangdujiao commented 3 weeks ago

Can we set 1 at multiple bit? like 'b001001 for trTeFilterMatchChoiceEcauseLow value

IainCRobertson commented 3 weeks ago

Yes you can set multiple bits. That’s why it’s a bit vector. ‘Choice’ in the name indicates it is multiple choice, allowing you to pick any combination you want.

Whether it matches interrupts, exceptions or both depends on whether you enable matching on the ‘int’ bit. If this is not enabled, it will match both, and if it is enabled it will match interrupts if the ‘value’ bit is 1, or exceptions if it’s 0.

Apologies for not using the exact field names but I’m on vacation without access to the spec.

From: zhangdujiao @.> Sent: Thursday, August 22, 2024 9:27:52 AM To: riscv-non-isa/riscv-trace-spec @.> Cc: Robertson, Iain (DI SW ICS DDCP TST RD EAH) @.>; Comment @.> Subject: Re: [riscv-non-isa/riscv-trace-spec] Does the tval comparison require itype = 1 or 2? (Issue #135)

Can we set 1 at multiple bit? like 'b001001 for trTeFilterMatchChoiceEcauseLow value

— Reply to this email directly, view it on GitHubhttps://github.com/riscv-non-isa/riscv-trace-spec/issues/135#issuecomment-2304078987, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALQOPSXBSEL5BFUTD2L5MUTZSWOIRAVCNFSM6AAAAABMWCSMP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBUGA3TQOJYG4. You are receiving this because you commented.Message ID: @.***>

zhangdujiao commented 2 weeks ago

Yes you can set multiple bits. That’s why it’s a bit vector. ‘Choice’ in the name indicates it is multiple choice, allowing you to pick any combination you want.

great! have a nice trip:)