Closed wmat closed 8 months ago
@IainCRobertson, what are your plans for getting this reviewed?
Hi Jeff. I reviewed the Asciidoc version of the spec with Bill prior to this PR, but it wasn't clear to me who was responsible for merging this. I can review, and if I'm happy that it is an accurate transformation from LaTeX, are you happy for me to just merge, or does someone else need to bless it off?
Feel free to merge, Iain.
Bill Traynor Documentation Build and Release Engineer RISC-V International
On Tue, Feb 27, 2024 at 5:35 PM IainCRobertson @.***> wrote:
Hi Jeff. I reviewed the Asciidoc version of the spec with Bill prior to this PR, but it wasn't clear to me who was responsible for merging this. I can review, and if I'm happy that it is an accurate transformation from LaTeX, are you happy for me to just merge, or does someone else need to bless it off?
— Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-trace-spec/pull/91#issuecomment-1967786340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN6ZGO3W6H4EEUPZPL7OTYVZNURAVCNFSM6AAAAABCCFA6COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXG44DMMZUGA . You are receiving this because you authored the thread.Message ID: @.***>
Reviewed and looks okay.
Done 😊.
I assume you or Jeff will take care of publishing and updating the Technical Specification page to link to the new asciidoc based PDF?
Iain
From: Bill Traynor @.> Sent: Tuesday, February 27, 2024 11:11 PM To: riscv-non-isa/riscv-trace-spec @.> Cc: Robertson, Iain (DI SW ICS TST RD EAH) @.>; Mention @.> Subject: Re: [riscv-non-isa/riscv-trace-spec] Move spec to AsciiDoc (PR #91)
Feel free to merge, Iain.
Bill Traynor Documentation Build and Release Engineer RISC-V International
On Tue, Feb 27, 2024 at 5:35 PM IainCRobertson @.<mailto:@.>> wrote:
Hi Jeff. I reviewed the Asciidoc version of the spec with Bill prior to this PR, but it wasn't clear to me who was responsible for merging this. I can review, and if I'm happy that it is an accurate transformation from LaTeX, are you happy for me to just merge, or does someone else need to bless it off?
— Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-trace-spec/pull/91#issuecomment-1967786340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN6ZGO3W6H4EEUPZPL7OTYVZNURAVCNFSM6AAAAABCCFA6COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXG44DMMZUGA . You are receiving this because you authored the thread.Message ID: @.<mailto:@.>>
— Reply to this email directly, view it on GitHubhttps://github.com/riscv-non-isa/riscv-trace-spec/pull/91#issuecomment-1967879519, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALQOPSQGI2ZN337AP7VPKMDYVZRWXAVCNFSM6AAAAABCCFA6COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXHA3TSNJRHE. You are receiving this because you were mentioned.Message ID: @.**@.>>
Yes, we’ll take care of that.
Bill Traynor Documentation Build and Release Engineer RISC-V International
On Thu, Feb 29, 2024 at 8:39 PM IainCRobertson @.***> wrote:
Done 😊.
I assume you or Jeff will take care of publishing and updating the Technical Specification page to link to the new asciidoc based PDF?
Iain
From: Bill Traynor @.> Sent: Tuesday, February 27, 2024 11:11 PM To: riscv-non-isa/riscv-trace-spec @.> Cc: Robertson, Iain (DI SW ICS TST RD EAH) @.>; Mention @.> Subject: Re: [riscv-non-isa/riscv-trace-spec] Move spec to AsciiDoc (PR
91)
Feel free to merge, Iain.
Bill Traynor Documentation Build and Release Engineer RISC-V International
On Tue, Feb 27, 2024 at 5:35 PM IainCRobertson @.<mailto:@.>>
wrote:
Hi Jeff. I reviewed the Asciidoc version of the spec with Bill prior to this PR, but it wasn't clear to me who was responsible for merging this. I can review, and if I'm happy that it is an accurate transformation from LaTeX, are you happy for me to just merge, or does someone else need to bless it off?
— Reply to this email directly, view it on GitHub < https://github.com/riscv-non-isa/riscv-trace-spec/pull/91#issuecomment-1967786340>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAN6ZGO3W6H4EEUPZPL7OTYVZNURAVCNFSM6AAAAABCCFA6COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXG44DMMZUGA>
. You are receiving this because you authored the thread.Message ID: @.<mailto:@.>>
— Reply to this email directly, view it on GitHub< https://github.com/riscv-non-isa/riscv-trace-spec/pull/91#issuecomment-1967879519>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/ALQOPSQGI2ZN337AP7VPKMDYVZRWXAVCNFSM6AAAAABCCFA6COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXHA3TSNJRHE>.
You are receiving this because you were mentioned.Message ID: @.**@.>>
— Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-trace-spec/pull/91#issuecomment-1972291618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN6ZHUXUAJ5QMF3WJ4SETYV7L45AVCNFSM6AAAAABCCFA6COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGI4TCNRRHA . You are receiving this because you authored the thread.Message ID: @.***>
PR for change to AsciiDoc.