search

riscv-non-isa / tg-nexus-trace

RISC-V Nexus Trace TG documentation and reference code
https://jira.riscv.org/browse/RVG-96
Creative Commons Attribution 4.0 International
44 stars 32 forks source link

Feedback on chapter 13 - RISC-V N-Trace (Nexus-based Trace) Specification #29

Closed ved-rivos closed 8 months ago

ved-rivos commented 1 year ago
  1. None of the sections here seem to qualify as normative specifications. These could be removed or moved to a non-normative appendix. If this is intended to help the TG in future these could be moved into a separate TODO document in the Github.
  2. Section 13.1 is very sparse. Either add more details or remove this. This section is not adding any normative specification value.
  3. Section 13.2 This could be removed, or maybe add as non-normative comment in I-CNT section
  4. Section 13.3 - Table 27 - This table does not have any normative specification. This could be removed.
mipsrobert commented 8 months ago

I am closing all N-Trace PDF related issues with same comments as all issues were handled via comments/discussions in SINGLE Google Docs. Relevant links are as follows:

Notes to N-Trace PDF: https://docs.google.com/document/d/1h__c0Kc7TQAWMh5bw9cNC9bl_IGqyY_ylPV14uc2xj0

N-Trace PDF rc20: https://github.com/riscv-non-isa/tg-nexus-trace/commit/221f6b1cef94c5f503554e0cb0deb4046dd49686 N-Trace for ARC review: https://github.com/riscv-non-isa/tg-nexus-trace/commit/1de77dcff1a75197232f72b8fe6863892da0cc74