search

riscv-non-isa / tg-nexus-trace

RISC-V Nexus Trace TG documentation and reference code
https://jira.riscv.org/browse/RVG-96
Creative Commons Attribution 4.0 International
44 stars 32 forks source link

Feedback on RISC-V Trace Control Interface Specification - Chapter 5 #34

Closed ved-rivos closed 7 months ago

ved-rivos commented 1 year ago

Section 5

  1. See note about moving the description of this register to the section 4.3
  2. "The major version...should change" -> "The major version is incremented when the modification breaks backward compatibility". " The minor version is incremented when the modification maintains backward compatibility"
  3. "Versions must be always.." -> is that a guideline for software? If so it should not be normative specfication.
  4. The long list of examples should be specified as a rule instead of specifying through examples. "Software should use the major version number to determine its compatibility with the component's implementation. Software that was implemented to be compatible with a major version may continue to operate even if the minor version of the component is higher than the version it was designed for. This is because minor versions, including experimental minor versions, are backward-compatible." The rest of the specification about causing warnings and aborts should not be normative.
  5. The note about what software should do is not useful as it does not add any information about this specification and is generally best practice that people versed in the art would know.
mipsrobert commented 7 months ago

All notes to Control PDF handled in 1.0.0_rc20.