search

riscv-non-isa / tg-nexus-trace

RISC-V Nexus Trace TG documentation and reference code
https://jira.riscv.org/browse/RVG-96
Creative Commons Attribution 4.0 International
44 stars 32 forks source link

Feedback on RISC-V N-Trace Specification 1.0.0 rc2.0 - Chapter 4 #46

Closed ved-rivos closed 7 months ago

ved-rivos commented 8 months ago

  1. Other trTeData... -> must be 0?

  2. trTeInstMode - HTM should be expanded consistently as "History Trace Messaging" (instead of History Branch Messaging)

  3. trTeProtocolMajor - "must be rejected by the trace tool" -> "must be rejected by the trace tool that if it is only compliant with version 1.0 of the N-trace protocol"

  4. trTeProtocolMinor - "Different values..." -> "When trTeProtocolMajor is 1, values other than 0 are considered down-compatible extension and should be accepted by the trace tool" (Qualification by trTeProtocolMajor is important)

  5. trTeInstMode - the description seems to imply that HTM mode must be allowed. Is that right? If the "must be allowed" was intended to qualify "One or more..." then suggest rewriting as: "One or more of the following values must be supported: 3: BTM (Branch Trace Messaging) mode 6: HTM (History Branch Messaging) mode"

Editorial:

  1. trTeEnable - Remove parenthesis around "potentiall...Unit" -> "Part of potentially shared Timestamp Unit. Controls generation of the TSTAMP field. See..."
mipsrobert commented 7 months ago

Addressed in 1.0.0_rc25 (or even earlier ...) version.