search

riscv-rust / e310x-hal

Implementation of the `embedded-hal` traits for E310x microcontrollers
17 stars 18 forks source link

Update embedded-hal dependency to 1.0.0-alpha.7 #42

Closed ahmedcharles closed 2 years ago

almindor commented 2 years ago

Looking good! I wonder if we should wait for https://github.com/rust-embedded/embedded-hal/pull/351 to land so we can update our SPI to it (since it's almost the same split). @Disasm what are your thoughts?

almindor commented 2 years ago

@ahmedcharles we'll need to bump the MSRV for this as well, including the CI scripts to match.

ahmedcharles commented 2 years ago

Sure, as I mentioned in another similar PR in a related repo, I'm just trying to get it all to compile/work before I propose a precise plan for releasing/merging it.

I'm fine with updating to using the new SPI interface once it's in an alpha.

almindor commented 2 years ago

I'm going to merge this as a step to get embedded-hal to alpha.8 with the SPI split next (I'll try to get a PR for that going soon).

almindor commented 2 years ago

@ahmedcharles I've had to revert this (and subsequent changes) since I found an odd problem with the SPI that only happened with release mode. I'm going to investigate in a new PR. There was also a logical error in the spi/bus.rs here the comparison should've been with iwrite. Even fixing that tho, the --release SPI failure was still there. I'll try to test these changes bit by bit to see where the problem occurs with the new PR.