search

riscv-rust / k210-pac

Peripheral access API crate (PAC) for K210 SoC, generated by svd2rust
29 stars 23 forks source link

KPU #14

Closed laanwj closed 5 years ago

laanwj commented 5 years ago

Add KPU (registers from src/drivers/include/kpu.h in Kendryte SDK)

Note: it looks like svd2rust is ignoring the 64-bit register size (will have the same problem with DMAC and FFT).

Disasm commented 5 years ago

Seems like svd-parser does not support size at peripheral level. It's not so easy to support it properly, because this size field belongs to registerPropertiesGroup and can be used on different levels.

I suggest moving the size definition into the register definitions.

laanwj commented 5 years ago

I suggest moving the size definition into the register definitions.

Okay, will do that, then.

laanwj commented 5 years ago

I'm fine with making the suggested changes

Disasm commented 5 years ago

Sorry, I can't commit these suggestions: there is no write permission to the corresponding branch of your repo. Could you commit them?

laanwj commented 5 years ago

Huh I must have accidentally turned that off for this PR, then. I've pushed a commit that should address them.

Disasm commented 5 years ago

Thanks!