search

riscv-software-src / riscof

BSD 3-Clause "New" or "Revised" License
63 stars 40 forks source link

bugfix: use os.makedirs instead of os.mkdir #109

Closed shareefj closed 3 months ago

shareefj commented 6 months ago

This commit updates riscof/framework/test to use os.makedirs(..., exists_ok=True) which prevents exceptions being raised when trying to rerun certain CLI commands that don't expect directories to already exist.

shareefj commented 6 months ago

This PR fixes one of the issues mentioned in #108

jamesbeyond commented 5 months ago

This minor improves looks good to me, happy to merge it into dev branch What do you think? @neelgala @allenjbaum

shareefj commented 5 months ago

Hi @jamesbeyond @neelgala @allenjbaum,

What's the official status of this repo as it seems to be pretty unmaintained? The few conversations I've had with others, admittedly very few and far distant from the project, had the opinion it had been left to rot. If that isn't the case then I'd be happy to submit a few more PRs for things as I get round to them. That one linked issue had a few suggestions of possible improvements.

The Incore documentation is also out of date and is due a clean-up so that it doesn't send people down the wrong path. If no one is supporting it any more, then perhaps just a big note on the front page to say it's out of date and not maintained would help people avoid spending time following incorrect instructions. I can't remember off the top of my head all the issues I found but it seemed that there were at least a couple of points that were just plain incorrect now.

It would be good to understand if and what anyone is maintaining. Cheers.

jamesbeyond commented 5 months ago

hi @shareefj

Thanks for providing feedbacks, I apology for not able to get back on those PRs with a timely manner. one major reason is because most of people working as part-time on those repos, and we are short for maintainers, so the progress are bit slow But now we are putting the repo governance guidelines together, and trying to assign more maintainers helping with us with this. So looking forward to speed up the PR review progress. If you are interested, please join ACT SIG and discuss with us via fortnightly zoom meetings. https://lists.riscv.org/g/sig-arch-test

one thing I can confirm is , this is one of the main repo we are maintaining, and maybe the docs are bit out of date, we are trying to get that up-to-date as well.

shareefj commented 5 months ago

OK, thanks. That's great news.