search

riscv-software-src / riscof

BSD 3-Clause "New" or "Revised" License
62 stars 39 forks source link

riscv_isac dependency not updated #122

Open 5hayanB opened 1 month ago

5hayanB commented 1 month ago

Cloned the riscof framework via the command which went smoothly:

pip3 install git+https://github.com/riscv/riscof.git

However, running riscof via the command:

riscof --verbose info arch-test --clone

I am greeted with the following error:

File "$HOME/.venv/bin/riscof", line 5, in <module>
    from riscof.cli import cli
  File "$HOME/.venv/lib/python3.12/site-packages/riscof/cli.py", line 18, in <module>
    import riscof.framework.main as framework
  File "$HOME/.venv/lib/python3.12/site-packages/riscof/framework/main.py", line 11, in <module>
    from riscv_isac.isac import preprocessing
ImportError: cannot import name 'preprocessing' from 'riscv_isac.isac' ($HOME/.venv/lib/python3.12/site-packages/riscv_isac/isac.py)

On debugging the problem, I found out that the recent commit dddbc52 added import statements from isac.py of the dev branch. But the riscv_isac dependency is not updated in requirements.txt. Reverting to commit d38859f fixes the problem.

stnolting-ims commented 1 month ago

I can confirm this bug (https://github.com/stnolting/neorv32-riscof/actions/runs/10156350492/job/28086317621#step:7:43).

Reverting to commit d38859f fixes the problem.

This seems to fix this (as a temporary workaround).

quswarabid commented 1 month ago

+1

stnolting commented 1 month ago

It this going to be fixed? Shall we provide a PR to address this?