Added return code of 1 if any test failed

riscv-software-src / riscof

BSD 3-Clause "New" or "Revised" License

62 stars 40 forks source link

Added return code of 1 if any test failed #15

Closed nadiga-ventana closed 3 years ago

nadiga-ventana commented 3 years ago

@neelgala Please review

pdonahue-ventana commented 3 years ago

This is basically the same as https://gitlab.com/incoresemi/riscof/-/merge_requests/82 which was never reviewed. @neelgala: What are your thoughts on returning non-zero on test failures so that higher-level scripts can detect that something is wrong?

neelgala commented 3 years ago

Apologies for not getting to this earlier..

This does make sense. I would suggest adding that logger statement as was done in the old PR. Also to accept this I will need you to do the following:

rebase to master
create entry in changelog for a patch version
bump the patch version using the command mentioned here

nadiga-ventana commented 3 years ago

@neelgala I have completed the mentioned steps. I also noticed that in the master the riscof/main.py has been deleted. I added it back in my pull request, but probably the recent changes has made my update moot.

neelgala commented 3 years ago

yea.. I was just going to say the same.. let me fix this in a separate PR.. keep this open until then. @pawks fyi

neelgala commented 3 years ago

https://github.com/riscv-software-src/riscof/pull/21 should fix what was attempted in this PR

neelgala commented 3 years ago

closing this since the feature now exists on the main branch. Thanks for contribution :)