search

riscv-software-src / riscof

BSD 3-Clause "New" or "Revised" License
61 stars 39 forks source link

D extension must have F and D as part of ISA string #62

Closed ptprasanna closed 2 years ago

ptprasanna commented 2 years ago

https://github.com/riscv-software-src/riscof/blob/a003752ff95dd5f9153c323dc2eb8ff7a0426dd9/riscof/framework/main.py#L132

As per the spec "The D extension depends on the base single-precision instruction subset F", which requires both F and D to be passed as part of the ISA string in-order to execute the double precision tests. So when we run a case with flen = 64, the current code always passed it as 32 and the statement under elif won't get executed at all for the D extension tests.

neelgala commented 2 years ago

the elif should just be an if. please raise a PR with the fix.

ptprasanna commented 2 years ago

@neelgala It's done here.

ptprasanna commented 2 years ago

This is fixed with this merge.