search

riscv-software-src / riscof

BSD 3-Clause "New" or "Revised" License
63 stars 40 forks source link

riscof_model.py fixes: don't use __init__ return value; use make -k. Fixes #71, #73. #72

Closed gsmecher closed 1 year ago

gsmecher commented 1 year ago

This would ordinarily be too nit-picky even in a code review, and I'd leave it alone (and would not expect anyone to merge it.) However, this code is used as a template and will proliferate. It's already showed up in a few RISCOF integrations into third-party RISC-V cores.

pawks commented 1 year ago

Hi @gsmecher. Thanks for the PR. Could you also address issue #73 in this PR and update the version accordingly(ref).

gsmecher commented 1 year ago

Thanks, @pawks - please take a look.