search

riscv-software-src / riscof

BSD 3-Clause "New" or "Revised" License
63 stars 40 forks source link

Docker install of SAIL does not seem to be supported by risocf_sail_cSim.py plugin template #99

Open Barabas5532 opened 11 months ago

Barabas5532 commented 11 months ago

In this documentation page, https://riscof.readthedocs.io/en/latest/installation.html#install-plugin-models, there is an option to install the SAIL emulator as a docker image. After installing the docker image, and trying to run the tests, I get this error:

   ERROR | riscv_sim_RV32: executable not found. Please check environment setup.

It looks like the project template does not care about the docker flag in the config, and assumes that SAIL is installed locally. It never reads the docker or image parameters in the config, and never calls out to docker. The only references I could find to docker in this repo are in the docs.

https://github.com/riscv-software-src/riscof/blob/108fa2d4e824b3e37fcff82e4fbbb7243127320b/riscof/Templates/setup/sail_cSim/riscof_sail_cSim.py#L31-L32

https://github.com/riscv-software-src/riscof/blob/108fa2d4e824b3e37fcff82e4fbbb7243127320b/riscof/Templates/setup/sail_cSim/riscof_sail_cSim.py#L74-L75

Is there actually no docker support in the built-in SAIL plugin or am I missing something?

Barabas5532 commented 11 months ago

Seems like docker support is available in this version of the plugin: https://gitlab.com/incoresemi/riscof-plugins/-/commit/2305fbf12a0fdc44a0a26821e53f445471a93cc5

Why is there a separate copy of the plugin being maintained elsewhere?