search

riscv-software-src / riscv-isac

BSD 3-Clause "New" or "Revised" License
32 stars 55 forks source link

Pluggy should be in install_requires; pytest shouldn’t #64

Open alexshpilkin opened 1 year ago

alexshpilkin commented 1 year ago

Since https://github.com/riscv-software-src/riscv-isac/pull/8, there has been a dependency on pluggy which is not listed in install_requires / requirements.txt.

On the other hand, as best as I can tell, pytest is only required to run tests (which is reasonable), yet is present in install_requires instead of only in tests_require, thus requiring every riscv_isac user to have it on their computer (which is not). It would be better to move it to the latter.

pawks commented 1 year ago

@alexshpilkin Thanks for filing the issue. Would you be willing to raise a PR for the same?

alexshpilkin commented 1 year ago

@pawks I’m fine doing that, sure. Do you want to make a separate test_requirements.txt or just special-case pytest for now? (I could even imagine comment-separated sections in the current requirements.txt file, but that sounds more fancy that this tiny problem is worth, honestly.)

pawks commented 1 year ago

Its better to have a separate test_requirements.txt than try to separate the requirements.txt into sections.