search

riscv-software-src / riscv-tests

Other
823 stars 437 forks source link

debug: use TCL-RPC to fetch results of OpenOCD commands instead of parsing log file #522

Closed aap-sc closed 7 months ago

aap-sc commented 7 months ago

Quick and dirty fix for https://github.com/riscv-software-src/riscv-tests/issues/520

aap-sc commented 7 months ago

@timsifive could you please take a look?

aap-sc commented 7 months ago

Note to reviewers:

  1. The patch requires nc (netcat) utility to be present on a host system. I hope this is not a big deal since nc is pretty lightweight utility.
  2. It looks like I forgot to cleanup resources. If there is no objections against the suggested approach - I'll update the patch (I think I need to extend __del__ method of OpenOCD class to close the spawned process).
timsifive commented 7 months ago

Can you address the pylint complaints for this PR?

aap-sc commented 7 months ago

Can you address the pylint complaints for this PR

Sure! I'm in the middle of it...

aap-sc commented 7 months ago

Can you address the pylint complaints for this PR?

Done.

Note: also addressed comments by @en-sc

timsifive commented 7 months ago

pylint is still failing. (I'm commenting here because I'm not sure if you get notified about that automatically.)

aap-sc commented 7 months ago

pylint is still failing. (I'm commenting here because I'm not sure if you get notified about that automatically.)

My bad. I was in a hurry and submitted an update as soon as I've tested these changes with OpenOCD. Never bothered to check if a new issue is introduced.

Addressed.

en-sc commented 7 months ago

@timsifive, can you please re-run OpenOCD pipelines failed due to this issue: https://github.com/riscv/riscv-openocd/actions/runs/6784073074/job/18460094331?pr=928 https://github.com/riscv/riscv-openocd/actions/runs/6822095851/job/18553551474?pr=959 https://github.com/riscv/riscv-openocd/actions/runs/6823520568/job/18557613980?pr=961

timsifive commented 7 months ago

They're all running now.