search

riscv-software-src / riscv-tests

Other
906 stars 463 forks source link

syscalls: avoid -Wformat warning #576

Open xypron opened 3 months ago

xypron commented 3 months ago

For printing uintptr_t use %zd.

benchmarks/common/syscalls.c: In function ‘_init’:
benchmarks/common/syscalls.c:118:36: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘uintptr_t’ {aka ‘long unsigned int’} [-Wformat=]
  118 |       pbuf += sprintf(pbuf, "%s = %d\n", counter_names[i], counters[i]);
      |                                   ~^                       ~~~~~~~~~~~
      |                                    |                               |
      |                                    int                             uintptr_t {aka long unsigned int}
      |                                   %ld
aswaterman commented 3 months ago

z is for size_t. Don't you want something like "%s = %" PRIdPTR "\n"?