search

riscv-software-src / riscv-tests

Other
902 stars 463 forks source link

[debug] Reserve triggers propperly in HwbpManual #581

Closed en-sc closed 2 months ago

en-sc commented 2 months ago

https://github.com/riscv-collab/riscv-openocd/pull/1111 introduces a change in OpenOCD behavior: a manual trigger should be manually removed to step/resume from it. This was not concidered in previous stop-gap solutions (76ff703d9161945354e334afa45c5dfe7680da60 and 8cc4918e904ca009cd85350fadf6f44e91eca13c)

This commit:

  1. Determines if reserve trigger is supported by the target. This can be removed once https://github.com/riscv-collab/riscv-openocd/pull/1111 is merged.
  2. Marks HwbpManual test as not applicable in case reserve trigger is not supported.
  3. Accounts for the change in OpenOCD's behavior when stepping from a manual BP.
  4. Cleans up some minor mistakes in HwbpManual