Open kbroch-rivosinc opened 1 week ago
I'm not sure we can rename it to .json5
. According to the devcontainer spec, this file must be named devcontainer.json
. Further, the spec says it is "JSON with comments," not specifically JSON5.
Ok
In the short term, this file can just be removed from check-json
hook.
In the long term, I'll see about getting a check-json-with-comments
in pre-commit-hooks repo where it has already been discussed here:
This might be a don't care but currently this file: https://github.com/riscv-software-src/riscv-unified-db/blob/main/.devcontainer/devcontainer.json#L12 is marked as
.json
and therefore can't have comments.If this format is acceptable for devcontainers I'd suggest renaming it
.json5
If not we can just ignore it when check-json is put in place.